Conversation
Comment on lines
+4
to
+5
| private String carName; | ||
| private int carSpeed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации
Comment on lines
+13
to
+19
| public String getName() { | ||
| return carName; | ||
| } | ||
|
|
||
| public int getCarSpeed() { | ||
| return carSpeed; | ||
| } |
There was a problem hiding this comment.
Можно убрать две функции - геттеры, сделать переменные публичными и добавить к ним модификатор final - так часто делают с классами, у которых переменные инициализируются в конструкторе и никогда не меняются (дата классы)
Comment on lines
+5
to
+14
| Auto winner = cars.get(0); | ||
| int theBiggestDistance = 0; | ||
| for (Auto car : cars) { | ||
| int distance = car.getCarSpeed() * 24; | ||
| if (distance > theBiggestDistance) { | ||
| theBiggestDistance = distance; | ||
| winner = car; | ||
| } | ||
| } | ||
| return winner; |
There was a problem hiding this comment.
Здесь можно избавиться от этого цикла и хранения машин в массиве, если определять текущую машину-победителя при чтении данных, тем самым программа будет требовать меньше памяти и работать быстрее
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.