Modify vmtksurfaceendclipper to clip based on centerline information#200
Merged
rlizzo merged 3 commits intovmtk:masterfrom Jan 10, 2018
Merged
Modify vmtksurfaceendclipper to clip based on centerline information#200rlizzo merged 3 commits intovmtk:masterfrom
rlizzo merged 3 commits intovmtk:masterfrom
Conversation
Member
|
Thanks for this PR @kayarre! I'm really sorry it took so long to review this! It works really well. Nice Job! Also, I meant to just push a few small changes to your PR before merging it (just updated the docstring and simplified some expressions), but it appears that I have royally screwed up and somehow merged in every commit to master from the point you branched to now... Not entirely sure how that happened. Sorry about the confusion, will fix now. |
Member
|
Ok. history crisis averted by rebasing on master. Merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per comments from @rlizzo in #196 I added clipping using centerline information feature to the vmtksurfaceendclipper.
This modification provides a means to use the normal information from the frenet frame of reference along the centerline to clip at inlet and outlet locations. The seed selection requires that the users knows the inlet and outlet direction used in the centerline generation such that the proper normal direction is applied in the clipping.
The issue with the current implementation of surfaceendclipper is two things.
The additions also includes removing the use of python dictionaries in the for loop.