Translations 2#35
Merged
tuna2134 merged 2 commits intovoicevox-client:mainfrom May 19, 2023
maamokun:translations-2
Merged
Conversation
tuna2134
approved these changes
May 19, 2023
scarletcafe
reviewed
May 19, 2023
| ---------- | ||
| text: str | ||
| 文字 | ||
| Text to synthesize |
There was a problem hiding this comment.
Mora are returned from /accent_phrases, thus they are already parsed - the text is not parsed again because it is already converted into the other data which the synthesizer actually uses
| Text to synthesize | ||
| consonant: str | ||
| 子音の音素 | ||
| Start of consonants |
There was a problem hiding this comment.
This is a mora - there is only one consonant.
| Pronounciation length of consonants | ||
| vowel: str | ||
| 母音の音素 | ||
| Start of vowels |
There was a problem hiding this comment.
This is a mora - there is only one vowel.
| Start of vowels | ||
| vowel_length: int | ||
| 母音の音長 | ||
| Length of vowels |
There was a problem hiding this comment.
This should have the same wording as the other length attribute.
| Length of vowels | ||
| pitch: int | ||
| ピッチ | ||
| ピッチ //Pitch of the voice |
There was a problem hiding this comment.
This isn't the correct way to do comments in docstrings, and it shouldn't be a comment anyway to match the other fields.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.