-
-
Notifications
You must be signed in to change notification settings - Fork 376
Allow virtualenv definitions to share the same requirements file#6
Merged
stankevich merged 2 commits intovoxpupuli:masterfrom Mar 14, 2013
Merged
Allow virtualenv definitions to share the same requirements file#6stankevich merged 2 commits intovoxpupuli:masterfrom
stankevich merged 2 commits intovoxpupuli:masterfrom
Conversation
added 2 commits
March 11, 2013 14:20
There was a dependency between python::virtualenv and python::requirements. Basically, the virtualenv wanted to initialize requirements, but requirements depended on the virtualenv being created already, resulting in: err: Could not apply complete catalog: Found 1 dependency cycle: (Exec[python_requirements_check_/usr/share/err/repo/requirements.txt] => Python::Requirements[/usr/share/err/repo/requirements.txt] => Exec[python_virtualenv_/usr/share/err/python3] => Python::Requirements[/usr/share/err/repo/requirements.txt] => Exec[python_requirements_check_/usr/share/err/repo/requirements.txt])
stankevich
added a commit
that referenced
this pull request
Mar 14, 2013
Allow virtualenv definitions to share the same requirements file
Collaborator
|
Thanks! |
stankevich
added a commit
that referenced
this pull request
Sep 1, 2015
Allow virtualenv definitions to share the same requirements file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to do the following, but this causes resources to be declared twice:
With these changes, this is now possible. Note that this pull request automatically brings in the commit from #4 so if you do not intend to merge this one, let me know and I will pull those changes out of it.