vector.__repr__ method now follows convention#231
Merged
mwcraig merged 2 commits intovpython:masterfrom Jun 8, 2023
Merged
Conversation
Contributor
|
Thanks @aherrera1721 for raising this issue and fixing it so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
vector.__repr__method to follow the Python convention which states, "If at all possible, [the returned value] should look like a valid Python expression that could be used to recreate an object with the same value (given an appropriate environment)."Now, calling
eval(repr(v))(wherevis avector) returns an equivalentvector.