fix(react): migrate SCSS imports to local variables and fix Popup positioning#101
Merged
wangdicoder merged 2 commits intomasterfrom Apr 10, 2026
Merged
Conversation
…itioning - Move all component SCSS imports from @tiny-design/tokens/scss/variables to local ../../style/variables, decoupling component styles from the tokens package SCSS source - Slim down @tiny-design/tokens by removing legacy SCSS files in favour of the v2 CSS-variable + runtime approach - Fix Popup component scroll-following by adding a useLayoutEffect that calls Popper forceUpdate after every render, ensuring position stays in sync with layout changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tiny-design/tokens/scss/variablesto local../../style/variables, decoupling component styles from the tokens package SCSS source@tiny-design/tokensby removing legacy SCSS files (_variables.scss,_constants.scss,_theme.scss, etc.) in favour of the v2 CSS-variable + runtime approachuseLayoutEffect+Popper.forceUpdate()to keep position in sync after every renderRelease
patch@tiny-design/react,@tiny-design/tokensTest plan
pnpm buildto confirm tokens and react packages build successfullypnpm testto verify no regressions🤖 Generated with Claude Code