Skip to content

feat(config): add baseURL parameter to Cohere reranker #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bevzzz wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

feat(config): add baseURL parameter to Cohere reranker #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/io/weaviate/client6/v1/api/collections/rerankers/CohereReranker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import io.weaviate.client6.v1.internal.ObjectBuilder;

public record CohereReranker(
@SerializedName("baseURL") String baseUrl,
@SerializedName("model") String model) implements Reranker {

public static final String RERANK_ENGLISH_V2 = "rerank-english-v2.0";
Expand All @@ -32,12 +33,18 @@ public static CohereReranker of(Function<Builder, ObjectBuilder<CohereReranker>>
}

public CohereReranker(Builder builder) {
this(builder.model);
this(builder.baseUrl, builder.model);
}

public static class Builder implements ObjectBuilder<CohereReranker> {
private String baseUrl;
private String model;

public Builder baseUrl(String baseUrl) {
this.baseUrl = baseUrl;
return this;
}

public Builder model(String model) {
this.model = model;
return this;
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/io/weaviate/client6/v1/internal/json/JSONTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,10 +1362,12 @@ public static Object[][] testCases() {
{
Reranker.class,
Reranker.cohere(rerank -> rerank
Comment thread
bevzzz marked this conversation as resolved.
.baseUrl("example.com")
.model(CohereReranker.RERANK_ENGLISH_V2)),
"""
{
"reranker-cohere": {
"baseURL": "example.com",
"model": "rerank-english-v2.0"
}
}
Expand Down
Loading