Fixes to allow for gcloud deployment#539
Merged
mdipierro merged 4 commits intoweb2py:masterfrom May 23, 2021
Merged
Conversation
Contributor
|
Thank you. That procedure was designed to avoid gevent what it was
required. I agree makes no sense any more
…On Sat, May 22, 2021, 12:20 Luca de Alfaro ***@***.***> wrote:
So, it turns out the idea of installing modules in gae/lib/ is problematic.
The problem is that if there are modules that are BINARY, the binary
installed on the local computer is not what is needed in the google cloud.
This was breaking in particular mysqlclient , which was installed in binary
on my Mac.
I think in the end the use of requirements.txt is safer; in this way the
cloud uses whatever module is appropriate for it without us trying to guess.
I have fixed the installation procedure and updated the gae/README.md
------------------------------
You can view, comment on, or merge this pull request online at:
#539
Commit Summary
- This works
- This works, and is better
- fixed
File Changes
- *M* deployment_tools/gae/Makefile
<https://github.com/web2py/py4web/pull/539/files#diff-4e369086b074b3386d38531e60d541a46ad2ae52bad1b6c071d15b8450b47837>
(17)
- *M* deployment_tools/gae/README.md
<https://github.com/web2py/py4web/pull/539/files#diff-1b5fb18214c6a8bbe5d168198f721fad4bcfb5d7c31b7a3381cf3a9e59a7f0d2>
(1)
- *M* deployment_tools/gae/app.yaml
<https://github.com/web2py/py4web/pull/539/files#diff-5577df8bd19d29a2aad4adbd2fd1f4ea7565c323560bec873e6c8bf4d6377771>
(2)
- *M* deployment_tools/gae/requirements.in
<https://github.com/web2py/py4web/pull/539/files#diff-06ed0986c3d3ce63d6130a1f70b07d3d8b9dd3c6aa92eb26b1eeaf754aa813e8>
(2)
- *M* deployment_tools/gae/requirements.txt
<https://github.com/web2py/py4web/pull/539/files#diff-cd92bf491c226f1af8c0a8c4dcf978ec733c14341f32a5e90173c8cd7a0874dd>
(15)
Patch Links:
- https://github.com/web2py/py4web/pull/539.patch
- https://github.com/web2py/py4web/pull/539.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#539>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLZT56EB6DIS7UMQYGKDTTO77XJANCNFSM45K5NQVA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, it turns out the idea of installing modules in gae/lib/ is problematic.
The problem is that if there are modules that are BINARY, the binary installed on the local computer is not what is needed in the google cloud. This was breaking in particular mysqlclient , which was installed in binary on my Mac.
I think in the end the use of requirements.txt is safer; in this way the cloud uses whatever module is appropriate for it without us trying to guess.
I have fixed the installation procedure and updated the gae/README.md