Maintain Code Consistency With Video Lesson (Array Cardio Practice - Day 1)#456
Closed
Eduardo06sp wants to merge 2 commits intowesbos:masterfrom
Closed
Maintain Code Consistency With Video Lesson (Array Cardio Practice - Day 1)#456Eduardo06sp wants to merge 2 commits intowesbos:masterfrom
Eduardo06sp wants to merge 2 commits intowesbos:masterfrom
Conversation
Ovii2
approved these changes
Mar 7, 2025
Owner
|
nah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While watching the lesson video JavaScript Array Cardio Practice - Day 1, I noticed that problem 4 gave me unexpected results (where you calculate the total ages). I also noticed a few people in the comments were having the same issue.
So I dug deeper and noticed there were some additions to the inventors array that were not reflected in the video.
One of the first rules for contributing here:
So for the sake of consistency and avoiding confusion for newcomers following along, I believe it's best to revert these commits.