Open
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/widgetbook/widgetbook~1884 Documentation is deployed and generated using docs.page. |
|
@EArminjon is attempting to deploy a commit to the Widgetbook Team on Vercel. A member of the Team first needs to authorize it. |
f6875f0 to
065f639
Compare
065f639 to
11f2a45
Compare
Contributor
Author
|
Hum, maybe we can create a new function to call both 'setNewRoutePath' and 'updatePath()'. UpdatePath should be call to ensure that knobs panel are well closed if needed. We use actually the bellow code (not very beautiful) // ignore: implementation_imports https://github.com/widgetbook/widgetbook/pull/1884
import 'package:widgetbook/src/routing/routing.dart';
import 'package:widgetbook/widgetbook.dart';
...
// ignore: invalid_use_of_internal_member needed to clear knobs & panels
WidgetbookState.of(context).updatePath('/');
Router.of(context).routerDelegate.setNewRoutePath(AppRouteConfig(uri: Uri(path: '/'))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a dev I want to interact with navigation (for example to create a Home button, or a redirection).
List of issues which are fixed by the PR
You must list at least one issue.
Screenshots
If applicable, add screenshots to help explain the changes.
Checklist
///).If you need help, consider asking for advice on Discord.