Add UTC in the contest page#76
Conversation
BUG: T331225
samwilson
left a comment
There was a problem hiding this comment.
Thanks for working on this!
The "UTC" part needs to be able to be localised (because it is different in different languages), so each of these datetimes should be rewritten to use a message e.g. {{ msg( msg('datetime-formatted', [contest.start_date]) ) }} where the datetime-formatted message would be $1 (UTC).
Note also that #71 and #72 have also tackled this, so there might be things in those that are of use to you.
|
Thanks for the review. I committed the changes for localization. I went with For the languages: |
|
Sorry, I totally didn't mean to add two It's best not to include messages as parameters to other messages (known as patchwork messages), so I'd recommend just adding this new message on its own. For the other languages, that's great that you did the research etc., but there's no need to add them in as they'll be done by TranslateWiki.net. The translators ask us to leave them out; see https://www.mediawiki.org/wiki/Help:System_message#Changing_existing_messages |
|
Thank you for the review and guidance! I've updated the implementation to use On a related note, I wasn't aware that translations are exclusively handled by TranslateWiki.net until this discussion. It might be helpful if this information is documented in the CONTRIBUTING.md file or somewhere similar for contributors who may not know. If it’s already documented and I missed it, I apologize! Please let me know if there are any further changes needed. |
…d in other places too
|
Thanks! |
BUG: T331225