Skip to content

Fix formatting issues#139

Closed
imwithsam wants to merge 2 commits intoworkshopper:masterfrom
imwithsam:patch-1
Closed

Fix formatting issues#139
imwithsam wants to merge 2 commits intoworkshopper:masterfrom
imwithsam:patch-1

Conversation

@imwithsam
Copy link
Copy Markdown

The tabbing and spacing in one of the functions and in the console.log line are a little confusing. Correct this to make it easier to follow.

The tabbing and spacing in one of the functions and in the console.log line are a little confusing. Correct this to make it easier to follow.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this one has to be changed to a: 1, b: 8, c: 6. Notice a space between , and c.

@a0viedo
Copy link
Copy Markdown
Member

a0viedo commented Mar 25, 2016

@imwithsam are you still interested in landing this changes? I can merge it once the comments are adressed

@imwithsam
Copy link
Copy Markdown
Author

Looks like a couple of changes have been made to this file since my original PR

itzsaga added a commit that referenced this pull request Dec 29, 2016
@itzsaga itzsaga closed this Dec 29, 2016
acipalli added a commit to acipalli/javascripting that referenced this pull request Sep 8, 2017
* Clarification

Whether or not this line is needed depends on how much hand-holding we want this problem to have.

* Fix typo Stirng => String

* Added Lead Maintainers list.

* removed "SCOPE" from Add these challenges list.

* Updated links in il8n footer docs.

* Solves workshopper#172

* Update solution.md

* Fixed formatting issues workshopper#139

* updated lead maintainers list

* Adds a howto to localize the workshopper to new languages

* Update Node.js download link in README

* Improve zh-tw troubleshooting translation

* Fixed missing gitter badge (workshopper#200)

Updated missing Gitter badge in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants