Skip to content

Implement CS checking based on the WP_CLI_CS ruleset#89

Merged
thrijith merged 6 commits intomasterfrom
feature/use-phpcs
Apr 22, 2019
Merged

Implement CS checking based on the WP_CLI_CS ruleset#89
thrijith merged 6 commits intomasterfrom
feature/use-phpcs

Conversation

@thrijith
Copy link
Copy Markdown
Member

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #86

Related wp-cli/wp-cli#5179

Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
@thrijith thrijith requested a review from a team as a code owner April 21, 2019 13:41
@schlessera schlessera added the command:config Related to 'config' command label Apr 21, 2019
Copy link
Copy Markdown

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark, but this LGTM.

Fix CS in config-command.php src/Config_Command.php
@thrijith thrijith force-pushed the feature/use-phpcs branch from 9e52774 to 44e2838 Compare April 21, 2019 18:28
@schlessera schlessera added this to the 2.0.3 milestone Apr 22, 2019
@schlessera
Copy link
Copy Markdown
Member

@thrijith I added a few small changes. Please review them, and if it looks good to you, then this can be merged once the tests pass.

@thrijith thrijith merged commit b6fa3ae into master Apr 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-phpcs branch April 22, 2019 09:07
schlessera pushed a commit that referenced this pull request Jan 6, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command:config Related to 'config' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants