Skip to content

Change CoreUpgrader::download_package signature #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 2 commits into from
Apr 24, 2019
+4 −3
Merged

Change CoreUpgrader::download_package signature #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84ed54
Change `CoreUpgrader::download_package` signature
wojsmol Apr 24, 2019
02d014a
Update src/WP_CLI/Core/CoreUpgrader.php
schlessera Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/WP_CLI/Core/CoreUpgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ class CoreUpgrader extends DefaultCoreUpgrader {
*
* @access public
*
* @param string $package The URI of the package. If this is the full path to an
* existing local file, it will be returned untouched.
* @param string $package The URI of the package. If this is the full path to an
* existing local file, it will be returned untouched.
* @param bool $check_signatures Whether to validate file signatures. Default true.
* @return string|WP_Error The full path to the downloaded package file, or a WP_Error object.
*/
public function download_package( $package ) {
public function download_package( $package, $check_signatures = true ) {

/**
* Filter whether to return the package.
Expand Down