Fix handling of __FILE__ and __DIR__ constants in eval()'d code.#38
Merged
danielbachhuber merged 2 commits intomasterfrom Apr 10, 2019
Merged
Fix handling of __FILE__ and __DIR__ constants in eval()'d code.#38danielbachhuber merged 2 commits intomasterfrom
__FILE__ and __DIR__ constants in eval()'d code.#38danielbachhuber merged 2 commits intomasterfrom
Conversation
|
This caused regression while running from crontab file, require 'file.php' didn't work anymore as previously, requiring the file in the same folder than the called script. I had crontab * * * * * wp eval-file /directory/script.php script.php: and the /directory contained file.php Got error from the script.php file: unable to find file.php |
schlessera
pushed a commit
that referenced
this pull request
Jan 5, 2022
Fix handling of `__FILE__` and `__DIR__` constants in `eval()`'d code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a regular expression to match all
__FILE__and__DIR__constants that are not wrapped in quotes ( see https://regex101.com/r/9hXp5d/2/ ), we replace these with single-quoted strings that are therealpath()of the current file, or thedirname()of that file, respectively.Fixes #37