Skip to content

Improve __FILE__/__DIR__ regex pattern#44

Merged
schlessera merged 4 commits intomasterfrom
improve-file-dir-regex-pattern
Feb 6, 2020
Merged

Improve __FILE__/__DIR__ regex pattern#44
schlessera merged 4 commits intomasterfrom
improve-file-dir-regex-pattern

Conversation

@schlessera
Copy link
Copy Markdown
Member

The previous pattern would erroneously match a string like SOMETHING__FILE__.

See https://regex101.com/r/9hXp5d/4/ for the new pattern.

@schlessera schlessera requested a review from a team as a code owner February 5, 2020 09:54
@schlessera schlessera changed the title Improve __FILE__/__DIR__ regex pattern Improve __FILE__/__DIR__ regex pattern Feb 5, 2020
@schlessera schlessera added bug command:eval-file Related to 'eval-file' command labels Feb 5, 2020
@schlessera schlessera added this to the 2.0.6 milestone Feb 5, 2020
@schlessera schlessera merged commit d379732 into master Feb 6, 2020
@schlessera schlessera deleted the improve-file-dir-regex-pattern branch February 6, 2020 11:24
schlessera added a commit that referenced this pull request Jan 5, 2022
Improve `__FILE__`/`__DIR__` regex pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:eval-file Related to 'eval-file' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant