Skip to content

Fix multi lang uninstall #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielbachhuber merged 4 commits into from
May 1, 2017
Merged

Fix multi lang uninstall #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8716a9a
Allow Multiple language uninstall
1naveengiri Apr 29, 2017
bd01156
Add Functional test
1naveengiri Apr 29, 2017
5b5a240
Correct functional test for Scenario of WP version
1naveengiri Apr 29, 2017
7aac324
Revert correct functional test for Scenario of WP version
1naveengiri Apr 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions features/core-language.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,15 @@ Feature: Manage translation files for a WordPress install
Success: Language uninstalled.
"""

When I run `wp core language uninstall en_CA en_NZ`
Then the wp-content/languages/admin-en_CA.po file should not exist
And the wp-content/languages/en_CA.po file should not exist
And STDOUT should be:
"""
Success: Language uninstalled.
Success: Language uninstalled.
"""

When I try `wp core language uninstall en_GB`
Then STDERR should be:
"""
Expand Down
66 changes: 35 additions & 31 deletions src/WP_CLI/CommandWithTranslation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ protected function get_all_languages() {
/**
* Uninstall a given language.
*
* <language>
* <language>...
* : Language code to uninstall.
*
* ## EXAMPLES
Expand All @@ -412,45 +412,49 @@ protected function get_all_languages() {
public function uninstall( $args, $assoc_args ) {
global $wp_filesystem;

list( $language_code ) = $args;
$language_codes = $args;

$available = $this->get_installed_languages();

if ( ! in_array( $language_code, $available ) ) {
\WP_CLI::error( "Language not installed." );
}
foreach ($language_codes as $language_code) {

$dir = 'core' === $this->obj_type ? '' : "/$this->obj_type";
$files = scandir( WP_LANG_DIR . $dir );
if ( ! $files ) {
\WP_CLI::error( "No files found in language directory." );
}
if ( ! in_array( $language_code, $available ) ) {
\WP_CLI::error( "Language not installed." );
}

$current_locale = get_locale();
if ( $language_code === $current_locale ) {
\WP_CLI::warning( "The '{$language_code}' language is active." );
exit;
}
$dir = 'core' === $this->obj_type ? '' : "/$this->obj_type";
$files = scandir( WP_LANG_DIR . $dir );
if ( ! $files ) {
\WP_CLI::error( "No files found in language directory." );
}

// As of WP 4.0, no API for deleting a language pack
WP_Filesystem();
$deleted = false;
foreach ( $files as $file ) {
if ( '.' === $file[0] || is_dir( $file ) ) {
continue;
$current_locale = get_locale();
if ( $language_code === $current_locale ) {
\WP_CLI::warning( "The '{$language_code}' language is active." );
exit;
}

// As of WP 4.0, no API for deleting a language pack
WP_Filesystem();
$deleted = false;
foreach ( $files as $file ) {
if ( '.' === $file[0] || is_dir( $file ) ) {
continue;
}
$extension_length = strlen( $language_code ) + 4;
$ending = substr( $file, -$extension_length );
if ( ! in_array( $file, array( $language_code . '.po', $language_code . '.mo' ) ) && ! in_array( $ending, array( '-' . $language_code . '.po', '-' . $language_code . '.mo' ) ) ) {
continue;
}
$deleted = $wp_filesystem->delete( WP_LANG_DIR . $dir . '/' . $file );
}
$extension_length = strlen( $language_code ) + 4;
$ending = substr( $file, -$extension_length );
if ( ! in_array( $file, array( $language_code . '.po', $language_code . '.mo' ) ) && ! in_array( $ending, array( '-' . $language_code . '.po', '-' . $language_code . '.mo' ) ) ) {
continue;

if ( $deleted ) {
\WP_CLI::success( "Language uninstalled." );
} else {
\WP_CLI::error( "Couldn't uninstall language." );
}
$deleted = $wp_filesystem->delete( WP_LANG_DIR . $dir . '/' . $file );
}

if ( $deleted ) {
\WP_CLI::success( "Language uninstalled." );
} else {
\WP_CLI::error( "Couldn't uninstall language." );
}

}
Expand Down