Skip to content

Tests: Use different port numbers between scenarios#99

Merged
swissspidy merged 1 commit intomainfrom
fix/tests-compat
Mar 28, 2026
Merged

Tests: Use different port numbers between scenarios#99
swissspidy merged 1 commit intomainfrom
fix/tests-compat

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

@swissspidy swissspidy added the scope:testing Related to testing label Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hardcoded port from 8182 to 8185 in the server feature test to resolve a conflict. The review feedback suggests that using dynamic port allocation instead of hardcoded values would further improve test robustness and prevent future flakiness.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.0.18 milestone Mar 28, 2026
@swissspidy swissspidy marked this pull request as ready for review March 28, 2026 11:45
@swissspidy swissspidy requested a review from a team as a code owner March 28, 2026 11:45
Copilot AI review requested due to automatic review settings March 28, 2026 11:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the wp server functional tests to avoid port collisions between scenarios when launching local servers in the background.

Changes:

  • Change the Access wp-login.php scenario’s server port from 8182 to 8185.
  • Update the corresponding curl request to match the new port.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@swissspidy swissspidy merged commit 4e1cce5 into main Mar 28, 2026
68 checks passed
@swissspidy swissspidy deleted the fix/tests-compat branch March 28, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants