Skip to content

Implement CS checking based on the WP_CLI_CS ruleset#30

Merged
schlessera merged 2 commits intomasterfrom
feature/use-phpcs
Apr 24, 2019
Merged

Implement CS checking based on the WP_CLI_CS ruleset#30
schlessera merged 2 commits intomasterfrom
feature/use-phpcs

Conversation

@thrijith
Copy link
Copy Markdown
Member

Add a PHPCS ruleset using the new WP_CLI_CS standard.

Fixes #28

Related wp-cli/wp-cli#5179

Update .distignore and .gitignore with phpcs/phpunit config files
Update wp-cli-tests to 2.1
@thrijith thrijith added the scope:testing Related to testing label Apr 21, 2019
@thrijith thrijith requested a review from a team as a code owner April 21, 2019 05:51
Copy link
Copy Markdown

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor remarks.

Fix CS in widget-command.php src/Widget_Command.php src/Sidebar_Command.php
@thrijith thrijith force-pushed the feature/use-phpcs branch 2 times, most recently from 1cce64b to 15d017d Compare April 22, 2019 06:29
@schlessera
Copy link
Copy Markdown
Member

Test failures seem unrelated and tracked in #31 & #32. Merging this one anyway.

@schlessera schlessera added this to the 2.0.2 milestone Apr 24, 2019
@schlessera schlessera merged commit 6ff3db6 into master Apr 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-phpcs branch April 24, 2019 09:32
schlessera added a commit that referenced this pull request Jan 5, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt and enforce new WP_CLI_CS standard

3 participants