test[faustwp-core]: (#1940) add test coverage for sitemapIndexPath option#2321
Open
latenighthackathon wants to merge 2 commits intowpengine:canaryfrom
Open
test[faustwp-core]: (#1940) add test coverage for sitemapIndexPath option#2321latenighthackathon wants to merge 2 commits intowpengine:canaryfrom
latenighthackathon wants to merge 2 commits intowpengine:canaryfrom
Conversation
…xPath option Add three tests to createSitemaps.test.ts verifying sitemapIndexPath behavior in createRootSitemapIndex(): - Fetches from custom sitemapIndexPath when provided - Falls back to default /sitemap.xml when not provided - Trims leading/trailing slashes from sitemapIndexPath Closes wpengine#1940
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: cb09f51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
sitemapIndexPathconfiguration option increateRootSitemapIndex()had zero test coverage. This PR adds three tests verifying its behavior:createRootSitemapIndexfetches from the custom URL whensitemapIndexPathis provided (e.g./custom-sitemap-index.xml)/sitemap.xmlwhensitemapIndexPathis omittedsitemapIndexPathbefore constructing the fetch URLRelated Issues
Closes #1940
Testing
Confirm the issue (before the fix)
1. Verify no sitemapIndexPath tests exist:
Confirm the fix
2. Verify sitemapIndexPath tests are present:
3. Run the sitemap tests:
npx jest --config packages/faustwp-core/jest.config.js --verbose -- createSitemaps # Expected: 15 tests pass (12 existing + 3 new)Run the full test suite