fix: CI pnpm version mismatch and flaky E2E tests#33
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CI pipeline failures and flaky E2E tests by updating dependency versions and improving ESLint configuration. The primary focus is fixing a pnpm version mismatch that was causing CI failures after PR #32.
- Update pnpm version in CI from 9.12.3 to 10.17.1 to match package.json
- Extend ESLint configuration to handle nested config files with default exports
- Address ongoing E2E test flakiness issues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Updates pnpm version to match package.json dependency |
| eslint.config.js | Extends config file patterns to include nested directories |
- Extended import/no-default-export exception to **/*.config.* - Fixes warnings for vite.config.ts in packages/ and app/ - Config files conventionally use default exports
- Replace arbitrary waitForTimeout() with proper selector waits - Increase timeouts for slow CI environments (5s → 15s) - Use domcontentloaded instead of networkidle for initial navigation - Add explicit visibility checks for elements - Increase action timeout from 10s to 15s - Add navigation timeout of 30s - Better loading state detection with try/catch - More robust wait conditions before assertions Addresses #13
- Add e2e-test to needs array in all-checks job - Add e2e-test.result check in status validation - Ensures E2E tests must pass for PR merge
b79858b to
851528c
Compare
Closed
pipewrk
added a commit
that referenced
this pull request
Nov 8, 2025
fix: CI pnpm version mismatch and flaky E2E tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes CI failures on main after PR #32 merge and addresses flaky E2E tests.
Changes
1. CI Fixes
2. Flaky E2E Tests (Issue #13)
Related Issues
Testing
Status: 🚧 Work in progress - CI fixes complete, E2E investigation in progress