Fix bug with lost values on bounds and little optimization#37
Merged
yannrichet merged 1 commit intoyannrichet:masterfrom Oct 13, 2017
Merged
Fix bug with lost values on bounds and little optimization#37yannrichet merged 1 commit intoyannrichet:masterfrom
yannrichet merged 1 commit intoyannrichet:masterfrom
Conversation
Contributor
Author
|
@yannrichet forget add brackets for if block. My bad =( |
Merged
Contributor
Author
|
Here you can find original solution https://gist.github.com/maxkrivich/925c8e5aa3853a6766459cad0f6f9fb7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem code
jmathplot/src/main/java/org/math/plot/utils/Histogram.java
Lines 27 to 32 in cc3eb20
Description of the bug
Sometimes happens what some values just losing on distribution intervals.
Optimization
Obviously, one value cannot contain several different boundaries. That's why after that we have to break out the inner cycle.
Proposed solution