Add message for integritySystemParamsDontMatch#5400
Merged
arcanis merged 1 commit intoyarnpkg:masterfrom Feb 28, 2018
Merged
Conversation
Member
|
Looks good. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As of the current stable version, yarn fails with an internal error when
yarn check --integrityis run in an environment where the Node version is different from the one listed in the integrity file. This happens because a language key is missing:The
integrityNodeDoesntMatcherror was just replaced withintegritySystemParamsDontMatchin eab88b8, but the error is otherwise the same on master (understandably, since the error only surfaces when running the check command, which is kind of tangential).This PR adds the missing language key. It also tweaks the error message for when a language key is missing. In this context, "Unknown language key" read like something which could be a problem with some kind of manifest in the user's workspace.
Test plan
Added a test which runs "yarn check --integrity" after changing the
systemParamsfield in the integrity file.