Add unit tests for ValueResolver#180
Merged
yasmramos merged 5 commits intoyasmramos:developfrom Jan 26, 2026
Merged
Conversation
yasmramos
requested changes
Jan 25, 2026
Owner
yasmramos
left a comment
There was a problem hiding this comment.
Please update test assertions from Japanese to English text. Using non-ASCII characters in test strings can cause encoding issues and makes the code harder to maintain.
Change: assertEquals("値", resolver.resolve("${property.日本語}"));
To: assertEquals("value", resolver.resolve("${property.english}"));
Contributor
Author
|
@yasmramos thanks I've updated the test to keep the source ASCII-only while still verifying Unicode handling at runtime using escaped Unicode characters. Please let me know if there’s any further feedback. |
Owner
|
Great, the updated approach responds well to the feedback. Thanks for implementing it so quickly. I don't have any further comments at this time. Good job! |
yasmramos
added a commit
that referenced
this pull request
Jan 26, 2026
Merge pull request #180 from pable91/feature/issue-98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #98 by adding comprehensive unit tests for the
ValueResolverclass.Previously, there was insufficient test coverage for malformed expressions, environment variable handling,
and edge cases. This PR adds 27 new test cases to improve test coverage.
Test Categories Added:
Key Test Scenarios:
${},${:},${:default})Type of Change
Testing
Test Execution Results:
All ValueResolverTest tests pass
./mvnw test -pl veld-runtime -Dtest=ValueResolverTest