Closed
Conversation
Updated the indentation error I spotted int the snippet section 95-98
updating erroneous indentation
Owner
|
Hi @goyal-vi Thank you for the PR. However, I don't think that the unindented block is wrong. Did you try running it in the terminal? I am closing this pull request for now but if you encountered an error while trying to run the code please let me know and I can take a further look into it. |
Author
|
Hey Yasoob,
I come from a cpp background with block scopes, So did PR under the
assumption that the variable initialized inside the with statement will
scope out at the end of with statement, which is clearly not the case with
python.
Will follow your advice to try out things before reacting.
Thanks and regards
Vishnu Goyal
2 month old @python
…On Mon, Oct 29, 2018 at 12:55 AM M.Yasoob Ullah Khalid ☺ < ***@***.***> wrote:
Hi @goyal-vi <https://github.com/goyal-vi> Thank you for the PR. However,
I don't think that the unindented block is wrong. Did you try running it in
the terminal? I am closing this pull request for now but if you encountered
an error while trying to run the code please let me know and I can take a
further look into it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#178 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Apb46-6dv_veoKYxv1RXwbmrwKlRfCqkks5upgTDgaJpZM4X53vu>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an erroneous indentation in chapter 22, open Function.