feat: add placeholder setting for select elements#105
Merged
liamwalder merged 4 commits intodevelopfrom Mar 30, 2026
Merged
Conversation
Add a "Placeholder" input to the select options settings panel that manages a special disabled/hidden first option. The default select template now includes a "Select an option" placeholder out of the box. Made-with: Cursor
Remove selected attribute from placeholder options to avoid React warning. Set defaultValue="" on the select element in the canvas renderer, and add selected in the SSR HTML output for placeholder options. Made-with: Cursor
React does not support the selected attribute on <option> elements. Filter it out during attribute normalization to prevent the console warning for all option elements, including those from existing data. Made-with: Cursor
liamwalder
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a "Placeholder" text input to the select options settings panel that manages
a special disabled/hidden first
<option>element. The default select templatenow ships with a "Select an option" placeholder out of the box.
Changes
isPlaceholderflag toLayerSettingstype for marking placeholder optionsSelectOptionsSettingswith add/update/remove logicselectedattribute from<option>elements in the React canvas renderer to prevent console warningsdefaultValue=""on<select>elements with placeholder children in the canvasselectedattribute for placeholder options in SSR HTML outputTest plan
selectedon<option>Made with Cursor