fix: render horizontal rules in published rich text output#108
Merged
liamwalder merged 2 commits intodevelopfrom Mar 30, 2026
Merged
fix: render horizontal rules in published rich text output#108liamwalder merged 2 commits intodevelopfrom
liamwalder merged 2 commits intodevelopfrom
Conversation
Add horizontalRule handler to renderTiptapToHtml so <hr> elements appear in the generated HTML. Also treat horizontalRule as a block node during CMS rich text variable expansion to prevent it from being silently dropped inside paragraphs. Made-with: Cursor
liamwalder
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Horizontal rules (
<hr>) added via the rich text editor were not appearing in the published website HTML, especially on CMS collection pages where rich text field values are expanded inline.Changes
horizontalRulehandler torenderTiptapToHtmlwith properDEFAULT_TEXT_STYLESfallback for consistent stylinghorizontalRuleto theisBlockNodecheck inresolveRichTextVariablesso HR nodes are correctly lifted out of paragraphs during CMS rich text variable expansionTest plan
<hr>(type---) in a rich text layer on a regular page, publish, and verify it appears<hr>in a rich text layer on a CMS collection template page, publish, and verify it appears for each collection item<hr>inside a CMS rich_text field value, publish, and verify it renders in the published outputborder-t-[1px] border-[#aeaeae])Made with Cursor