fix: sort collection items before pagination in published site#118
Merged
liamwalder merged 2 commits intodevelopfrom Apr 1, 2026
Merged
fix: sort collection items before pagination in published site#118liamwalder merged 2 commits intodevelopfrom
liamwalder merged 2 commits intodevelopfrom
Conversation
When a collection layer uses field-based sorting (e.g. by date), the DB was paginating by manual_order first, then client-side sort only reordered that subset. This gave wrong results because the correct items for the sorted view might not be in the DB-returned page. Now fetch all items when field-based sorting is active, sort the full set, then apply limit/offset via slice to get the correct page. Made-with: Cursor
liamwalder
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix field-based sorting (e.g. by date) on published collection pages. Items were
sorted incorrectly because the DB paginated by
manual_orderfirst, thenclient-side sort only reordered that subset — giving the wrong items for the
requested sort order.
Changes
slice()Test plan
Made with Cursor