Skip to content

feat: add rich text image/link popover improvements#65

Merged
liamwalder merged 8 commits intodevelopfrom
feat/rich-text-image-alt-popover
Mar 24, 2026
Merged

feat: add rich text image/link popover improvements#65
liamwalder merged 8 commits intodevelopfrom
feat/rich-text-image-alt-popover

Conversation

@lunenas
Copy link
Copy Markdown
Collaborator

@lunenas lunenas commented Mar 20, 2026

Summary

Add image alt text editing popover to the rich text editor and improve the
link settings popover UX to match the sidebar LinkSettings component.

Changes

  • Add image alt text popover in the rich text toolbar (opens when clicking an image)
  • Add RichTextImageBlock component with selection ring indicator
  • Add RichTextImageWithNodeView TipTap extension for proper node selection
  • Refactor RichTextLinkPopover to use SettingsPanel with trash/close action buttons
  • Apply link changes immediately on edit instead of requiring an Apply button
  • Do not preselect URL type for new links, let the user choose
  • Use SelectTrigger onClear for link type removal in RichTextLinkSettings
  • Add w-full to SelectTrigger base styles
  • Adjust ghost button dark mode hover color

Test plan

  • In rich text editor, insert an image and click it — selection ring appears and alt text popover opens below the toolbar image button
  • Edit alt text in the popover — saves on close/blur
  • Click the x button in the image popover — closes and saves
  • In rich text editor, select text and click the link button — popover opens with no type preselected
  • Choose a link type and configure it — link is applied immediately without needing an Apply button
  • Click the trash icon on an existing link — link is removed
  • Click the x close button — popover closes
  • Use the clear icon inside the link type select to reset to no link
  • Verify SelectTrigger fills container width in all select dropdowns

lunenas added 3 commits March 19, 2026 17:02
Click an image in the rich text editor to select it and auto-open
an alt text popover anchored to the image toolbar button.

Made-with: Cursor
@lunenas lunenas linked an issue Mar 20, 2026 that may be closed by this pull request
@liamwalder liamwalder self-assigned this Mar 24, 2026
@liamwalder liamwalder merged commit 6a629ca into develop Mar 24, 2026
2 checks passed
@liamwalder liamwalder deleted the feat/rich-text-image-alt-popover branch March 24, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: ALT settings in rich-text for Image

2 participants