fix: filter CMS reference sub-options by allowed field types#82
Merged
liamwalder merged 2 commits intodevelopfrom Mar 24, 2026
Merged
fix: filter CMS reference sub-options by allowed field types#82liamwalder merged 2 commits intodevelopfrom
liamwalder merged 2 commits intodevelopfrom
Conversation
liamwalder
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference fields in CMS option dropdowns were showing all sub-options regardless of the type filter applied at the root level. For example, a rich-text field selector would show a reference group containing text, number, boolean fields instead of only rich-text fields.
Changes
referenceHasMatchingSubFieldsrecursive helper tofilterFieldGroupsByType— reference fields are now excluded when their referenced collection has no matching sub-fields (cycle-safe, checks recursively through nested references)allFieldsoption tofilterFieldGroupsByTypeto enable reference sub-field checking at the data levelCollectionFieldSelectorto derive effective allowed types from pre-filtered incoming groups and aly a singlefilterFieldGroupsByTypepass withallFields— fixes all consumers automatically with no call-site changesFieldSelectDropdownto passallFieldsto its own filter callCollectionFieldListcomponent andcollectionLabelpropTest plan
Add 2 collections, one having a reference field to the other collection.
rich_textfields (and references that contain rich-text sub-fields)