Skip to content

fix: respect theme preference on builder navigation#95

Merged
liamwalder merged 2 commits intodevelopfrom
fix/light-mode
Mar 26, 2026
Merged

fix: respect theme preference on builder navigation#95
liamwalder merged 2 commits intodevelopfrom
fix/light-mode

Conversation

@tristan-mouchet
Copy link
Copy Markdown
Collaborator

Summary

Fix light mode resetting to dark when navigating between builder sections
(Design, CMS, etc.). The DarkModeProvider was unconditionally forcing dark
mode on every pathname change within /ycode, ignoring the user's saved
theme preference.

Changes

  • Update DarkModeProvider to check localStorage theme preference before applying dark mode on builder routes
  • Use light/dark-aware text color for the save status indicator (Ready/Saving/Saved) in HeaderBar

Test plan

  • Select Light theme in the builder menu
  • Navigate between Design, CMS, and Settings — theme should stay light
  • Verify the save status text is visible in both light and dark modes
  • Select System theme and verify it follows OS preference across navigation
  • Refresh the page — theme should persist from localStorage

@tristan-mouchet tristan-mouchet added the Bug Something isn't working label Mar 25, 2026
@tristan-mouchet tristan-mouchet self-assigned this Mar 25, 2026
@liamwalder liamwalder self-assigned this Mar 26, 2026
@liamwalder liamwalder merged commit 7000ed0 into develop Mar 26, 2026
2 checks passed
@liamwalder liamwalder deleted the fix/light-mode branch March 26, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants