Conversation
cliraa
reviewed
Sep 22, 2024
README.md
Outdated
| - Verifying a tendermint block. | ||
| - Interacting with a user to answer a quiz. | ||
|
|
||
| Run one of the following commands to test zkRust. You can choose either risc0 or sp1: |
There was a problem hiding this comment.
Suggested change
| Run one of the following commands to test zkRust. You can choose either risc0 or sp1: | |
| Run one of the following commands to test zkRust. You can choose either Risc0 or SP1: |
README.md
Outdated
|
|
||
| To generate a proof of the execution of your code run the following: | ||
|
|
||
| - **Sp1**: |
README.md
Outdated
|
|
||
| # Acknowledgments: | ||
|
|
||
| ZK Rust was intioned and designed as a tool to make development on programs that use zkVM's easier and reduce deduplication of code for developers that want to experiment with zk on aligned layer. We want the work and contributions of the SP1 and Risc0 teams to the field of Zero Knowledge Cryptography. |
There was a problem hiding this comment.
Suggested change
| ZK Rust was intioned and designed as a tool to make development on programs that use zkVM's easier and reduce deduplication of code for developers that want to experiment with zk on aligned layer. We want the work and contributions of the SP1 and Risc0 teams to the field of Zero Knowledge Cryptography. | |
| ZK Rust was intended and designed as a tool to make development on programs that use zkVM's easier and reduce deduplication of code for developers that want to experiment with zk on aligned layer. We want the work and contributions of the SP1 and Risc0 teams to the field of Zero Knowledge Cryptography. |
README.md
Outdated
| ``` | ||
| Make sure to have [Risc0](https://dev.risczero.com/api/zkvm/quickstart#1-install-the-risc-zero-toolchain) installed with version `v1.0.1` | ||
|
|
||
| To generate your proof and send it to [Aligned Layer](https://github.com/yetanotherco/aligned_layer). First generate a local wallet keystore using `[cast](https://book.getfoundry.sh/cast/). |
There was a problem hiding this comment.
Suggested change
| To generate your proof and send it to [Aligned Layer](https://github.com/yetanotherco/aligned_layer). First generate a local wallet keystore using `[cast](https://book.getfoundry.sh/cast/). | |
| To generate your proof and send it to [Aligned](https://github.com/yetanotherco/aligned_layer). First generate a local wallet keystore using [cast](https://book.getfoundry.sh/cast/). |
README.md
Outdated
| └── main.rs | ||
| ``` | ||
|
|
||
| For using more complex programs you can import a separate lib/ crate into the . |
There was a problem hiding this comment.
I guess this line needs some changes. Maybe 'lib/crate' should be joined and the end of the line should be fixed.
cliraa
suggested changes
Sep 22, 2024
cliraa
left a comment
There was a problem hiding this comment.
I left a comment and some suggestions in the README file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite of zkRust: