Skip to content

Add keep throttle flag#2

Open
knechtR0Brecht wants to merge 1 commit intoyieldlab:masterfrom
knechtR0Brecht:add-keep-throttle-flag
Open

Add keep throttle flag#2
knechtR0Brecht wants to merge 1 commit intoyieldlab:masterfrom
knechtR0Brecht:add-keep-throttle-flag

Conversation

@knechtR0Brecht
Copy link
Copy Markdown

  • add --keep-throttle flag to apply/apply.go in order to keep throttle settings for topics after topic settings are applied

@knechtR0Brecht knechtR0Brecht force-pushed the add-keep-throttle-flag branch from 951b677 to 2481012 Compare March 30, 2026 14:35
@knechtR0Brecht knechtR0Brecht force-pushed the add-keep-throttle-flag branch 3 times, most recently from 063b719 to 38cc7f5 Compare April 7, 2026 09:33
Add a new `--keep-throttle` boolean flag to the apply command that allows
users to preserve replication throttle settings instead of having them
automatically removed after applying topic configurations.

This is particularly useful for topics where throttle settings
(leader.replication.throttled.replicas, follower.replication.throttled.replicas)
are intentionally configured in the topic YAML and should be maintained
across applies.

Due to the possibility of partition shuffling we need to apply the throttle config from the original topic definition file again in the end. During the partition shuffling step, the throttle settings will be overwritten per partition automatically and then deleted in the end, removing any wanted throttle settings from the configuration file or a previous set topic/broker throttle, those need to be restored.

Changes:
- Add --keep-throttle flag to apply command
- Skip automatic throttle removal when flag is set
- Update help documentation

Example usage:
  topicctl apply --keep-throttle --skip-confirm \
    --cluster-config cluster.yaml topics/my-topic.yaml
@knechtR0Brecht knechtR0Brecht force-pushed the add-keep-throttle-flag branch from 38cc7f5 to e6fba0f Compare April 7, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant