Open
Conversation
knechtR0Brecht
commented
Mar 20, 2026
- add --keep-throttle flag to apply/apply.go in order to keep throttle settings for topics after topic settings are applied
951b677 to
2481012
Compare
063b719 to
38cc7f5
Compare
Add a new `--keep-throttle` boolean flag to the apply command that allows
users to preserve replication throttle settings instead of having them
automatically removed after applying topic configurations.
This is particularly useful for topics where throttle settings
(leader.replication.throttled.replicas, follower.replication.throttled.replicas)
are intentionally configured in the topic YAML and should be maintained
across applies.
Due to the possibility of partition shuffling we need to apply the throttle config from the original topic definition file again in the end. During the partition shuffling step, the throttle settings will be overwritten per partition automatically and then deleted in the end, removing any wanted throttle settings from the configuration file or a previous set topic/broker throttle, those need to be restored.
Changes:
- Add --keep-throttle flag to apply command
- Skip automatic throttle removal when flag is set
- Update help documentation
Example usage:
topicctl apply --keep-throttle --skip-confirm \
--cluster-config cluster.yaml topics/my-topic.yaml
38cc7f5 to
e6fba0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.