Skip to content

Assignment two completion#2

Open
yitZhao21 wants to merge 2 commits intomainfrom
assignment-two
Open

Assignment two completion#2
yitZhao21 wants to merge 2 commits intomainfrom
assignment-two

Conversation

@yitZhao21
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Completing assignment two (Section 1 and 4 in the markdown file) and sql code uploaded as .sql file.

What did you learn from the changes you have made?

Using sql code to manipulate strings and datasets.

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

I could write code in a more succinct way without creating too many temp tables.

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Took some time to problem solve.

How were these changes tested?

Ran on local computers.

A reference to a related issue in your repository (if applicable)

N/A

Checklist

  • [ YZ ] I can confirm that my changes are working as intended

I have completed assignment 2 (sql portion) and added in my code.
Copy link
Copy Markdown

@kelichiu kelichiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total Point: 53/70

Section 1: 38/46

  • Order Table is actually the orders of new books from suppliers to refill the stock, not customer orders. Having relationship with Customer and Sales is incorrect.
  • Type 1 and Type 2 table structures proposal missing.
  • Employee_Shifts table is missing
  • Date Table seems to be dedicated to Employee_Shifts. This table should be designed in a way that can be used in combination with all tables that have Date values (Orders, Sales, Employee_Shifts). Common attributes of a Date table are: year, month, quarter, weekday…etc.

Section 2: 5/8

  • WINDOW FUNCTION Q1: When use ROW_NUMBER, the data of customer_id and market_date is not unique. We need to use GROUP BY to get the unique combination of customer_id and market_date in data.
  • UNION: Extra comma is generating an error in the section of CREATE TEMP TABLE DailySales_Max AS

Section 3: 2/8

  • INSERT: Typo in table name “products”. We should be inserting to product_unit table instead of unit_product
  • DELETE: You are deleting product by their ID. In the instruction, it's specified that we delete the product by not only ID, but also the timestamp. Imagine you have previously insert a product with an ID that already exist in the table, your approach would delete both of the records(new and old). We need to incorporate the checking of timestamp in order to make sure that we are deleting just the old record.
  • UPDATE:
    • Table to be altered is product_unit instead of unit_product
    • Table to be updated is product_unit instead of final_update

Section 4: 8/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants