Conversation
There was a problem hiding this comment.
Great work! You are almost there, you code is clean and well-written. Please address the following change request to complete the assignment:
You're currently checking whether all letters in word_b exist in word_a, but not whether they appear the same number of times. This means some non-anagrams might incorrectly return True.
Could you think of a way to also compare the frequency of each letter in both words?
Feel free to reach out if you have any questions!
…nditions. I tested the two conditions on the two hypothetical examples: apple / aple and apple / aaple.
Hello Xindi, please see the changes. Thanks. Andy |
xindizhang
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments. Great work! Your assignment 1 is complete – no changes needed.
One suggestion for future improvements: I suggest adding comments or brief documentation to your code. It’s a good practice that makes it easier for you to review and debug later, and helps teammates understand it quickly.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I added code to assignment 1 jupyter notebook to create anagram checker
What did you learn from the changes you have made?
I applied concepts such as functions and logic operators.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Mostly just following the logic of the program and making sure the tester cells produce correct outputs.
How were these changes tested?
I ran the tester cells after completing the code
A reference to a related issue in your repository (if applicable)
Checklist