Conversation
skarahoda
approved these changes
Sep 19, 2022
skarahoda
reviewed
Sep 19, 2022
skarahoda
approved these changes
Sep 19, 2022
f36b7dd to
dd195bb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Change description
Upgrade vulnerable dependency git-url-parse.
1efb7f8 is implemented as a remedy for the breaking change mentioned in git-url-parse release. It seems our use cases are not affected by this breaking change. Nevertheless, I put it to cover old behavior for http/https git repo URLs (while also fixing a problem for ssh git URLs with custom ports).
Changes are going to be backported to 1.1.x versions #104
Type of change
Related issues
Fixes #102
Checklists
Development
Security
Code review