Skip to content

fix: replace parse-git-config with internal ini parser#121

Merged
aykutbulca merged 1 commit intomainfrom
remove-parse-git-config
Jun 3, 2025
Merged

fix: replace parse-git-config with internal ini parser#121
aykutbulca merged 1 commit intomainfrom
remove-parse-git-config

Conversation

@aykutbulca
Copy link
Copy Markdown
Member

@aykutbulca aykutbulca commented May 30, 2025 •
edited
Loading

Change description

Removes the vulnerable parse-git-config package and replaces it with a simple ini parser for retrieving the necessary fields only.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Partially fixes #119.

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@aykutbulca aykutbulca marked this pull request as draft May 30, 2025 11:10
@aykutbulca aykutbulca force-pushed the remove-parse-git-config branch from f74c5fc to afcf3ae Compare May 30, 2025 12:54
@aykutbulca aykutbulca changed the title fix: use native commands for git config fix: replace parse-git-config with internal utility function May 30, 2025
@aykutbulca aykutbulca marked this pull request as ready for review May 30, 2025 13:00
@aykutbulca aykutbulca changed the title fix: replace parse-git-config with internal utility function fix: replace parse-git-config with internal utility May 30, 2025
@aykutbulca aykutbulca force-pushed the remove-parse-git-config branch from afcf3ae to 2a2bdbe Compare May 30, 2025 13:37
@aykutbulca aykutbulca changed the title fix: replace parse-git-config with internal utility fix: replace parse-git-config with internal ini parser May 30, 2025
@aykutbulca aykutbulca changed the title fix: replace parse-git-config with internal ini parser fix: replace parse-git-config with internal ini parser May 30, 2025
@aykutbulca aykutbulca force-pushed the remove-parse-git-config branch 2 times, most recently from 33ffbcc to 12ea7ed Compare May 30, 2025 17:34
@aykutbulca aykutbulca force-pushed the remove-parse-git-config branch 2 times, most recently from 854538f to 4cb21f1 Compare June 3, 2025 05:46
@aykutbulca aykutbulca force-pushed the remove-parse-git-config branch from 4cb21f1 to 6a04572 Compare June 3, 2025 05:54
@aykutbulca aykutbulca merged commit 9b9d92d into main Jun 3, 2025
1 check passed
@aykutbulca aykutbulca deleted the remove-parse-git-config branch June 3, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuksely yuksely Awaiting requested review from yuksely

2 more reviewers

@melsener melsener melsener approved these changes

@okan-cakmak okan-cakmak okan-cakmak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security vulnerabilities in dependencies

3 participants

@aykutbulca @melsener @okan-cakmak