Skip to content

Prepare the app for v2#93

Merged
skarahoda merged 4 commits intomainfrom
refactor/v2-prep
Nov 8, 2021
Merged

Prepare the app for v2#93
skarahoda merged 4 commits intomainfrom
refactor/v2-prep

Conversation

@skarahoda
Copy link
Copy Markdown

@skarahoda skarahoda commented Nov 8, 2021

Change description

  • refactor: Remove unreachable if branch
  • docs: Remove auto generated documentation
  • refactor: Remove styleguidist

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@skarahoda skarahoda self-assigned this Nov 8, 2021
yuqu
yuqu reviewed Nov 8, 2021
View reviewed changes
Comment thread src/commands/connect/plugin.ts Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skarahoda skarahoda requested a review from yuqu November 8, 2021 08:32
@skarahoda skarahoda merged commit 7270e69 into main Nov 8, 2021
@skarahoda skarahoda deleted the refactor/v2-prep branch November 8, 2021 11:20
@skarahoda skarahoda mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burakaraz burakaraz Awaiting requested review from burakaraz

@aykutbulca aykutbulca Awaiting requested review from aykutbulca

@yuksely yuksely Awaiting requested review from yuksely

@okan-cakmak okan-cakmak Awaiting requested review from okan-cakmak

1 more reviewer

@yuqu yuqu yuqu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skarahoda skarahoda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skarahoda @yuqu