Skip to content

Updated assignment_2.ipynb#2

Merged
zsadr2002 merged 1 commit intomainfrom
assignment_2
May 23, 2025
Merged

Updated assignment_2.ipynb#2
zsadr2002 merged 1 commit intomainfrom
assignment_2

Conversation

@zsadr2002
Copy link
Copy Markdown
Owner

@zsadr2002 zsadr2002 commented May 8, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes:

  1. Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. Change "/Users/zeinabsadr/Desktop/assignment_2_data/inflammation_01.csv" to ../../assignment_2_data/inflammation_01.csv"

  2. In Question 1, the requirement is to use readlines/readline method to read the csv file into a variable (which you have done properly) and use the variable in a for loop to print each row. The for loop is missing. Could you please add that part?

@zsadr2002
Copy link
Copy Markdown
Owner Author

Hello Anjali, I updated my file, is that correct ? Thanks.

@anjali-deshpande-hub
Copy link
Copy Markdown

I am not seeing the changes in assignment_2.ipynb. Perhaps, you forgot to push your changes to github.

@zsadr2002 zsadr2002 merged commit e5ade22 into main May 23, 2025
@anjali-deshpande-hub
Copy link
Copy Markdown

Hello,
Please make the review changes suggested above. Kindly re-open the PR. You can commit the changes and a learning support will re-review your changes.
The review process is iterative. Please don't close the PR/merge the PR until the PR is tagged as 'approved'.
Thank you.

@zsadr2002
Copy link
Copy Markdown
Owner Author

By mistake, I merged and closed that. I think you can see my changes for Assignment 2 now.

@anjali-deshpande-hub
Copy link
Copy Markdown

I am not sure which PR you want me to review now. Please revert this PR. Follow the steps outlined here to revert: https://github.com/UofT-DSI/onboarding/blob/main/onboarding_documents/submissions.md#handling-accidental-merges

@zsadr2002
Copy link
Copy Markdown
Owner Author

Screen Shot 2025-05-23 at 4 51 57 PM

@anjali-deshpande-hub
Copy link
Copy Markdown

Hello,
Please don't create a new PR for the fixes. The new PR (#3) has assigment_1.ipynb file changes as well. It should only contain assignment_2.ipynb file changes (like this PR). Kindly revert this PR. (#2).
Also, there is an error in the file that has been committed. Screenshot attached.
Screenshot 2025-05-23 172507

@zsadr2002
Copy link
Copy Markdown
Owner Author

Hi, is it fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants