[WIP] Update TRD validation macro for FST#9054
[WIP] Update TRD validation macro for FST#9054martenole wants to merge 1 commit intoAliceO2Group:devfrom
Conversation
|
@martenole I still like the idea of pretty pictures ;-) to do the verification, it allows for easier debugging if something is wrong, maybe leave it in as an option? But yes a 1 to 1 comparison is probably better. As for the digits, looking now. |
|
But then you would actually need plots for everything, not just the detector number. And even then I am not sure how much the plots would help, if there were differences? In principle I expect the exact same number of tracklets and for every digit which is in the TF file an exact match in the simulation (there might be less digits, because of the calibration triggers). So I could also just break on the first tracklet/digit which does not have a match in simulation, right? |
|
Yes, I suppose what I am really proposing is heading into qc. Maybe I should consider the task at hand, testing the sim to raw to reco chain and 1 to 1 comparison is what is needed. It would however be nice to plot a pile of things in one macro and know kind of definitively if something is off with the digits and tracklets. |
|
Hello, |
|
1 or a million, I think I know what is wrong. At the moment just trying to sort out why the tracklets in the data taken over the weekend are test tracklet format. Then will get to this. |
|
Sure, the number of collisions in the FST is configurable. The comparison would be faster, if some matches would be found ;) |
|
@martenole chat on mattermost ;-) |
|
what is the status of this? Can this be merged? |
|
Sorry, not yet. Will remove WIP once ready |
|
Ok, digits problem is fixed in #PR9187. |
|
Closing, macro functionality included in #9373 |
Hi Sean,
I think it is better to do a one to one comparison of the digits and tracklets in the FST. Since I am not sure about the ordering I have two double loops now where I try to find a match for each digit and tracklet.
For the tracklets this works fine now when I ignore the PID values. So HCId, position etc are identical. For the digits however I can find only 15 matches out of almost 1 million digits. I don't really understand this, because when I compare the different spectra for e.g. ADC values they look identical. This is the case for all members of the digits class. Can it be that there is some mixup in during the conversion?
Cheers,
Ole