[WIP] Simple table level sharding implementation#129
Open
[WIP] Simple table level sharding implementation#129
Conversation
Contributor
auxten
commented
Dec 3, 2018
- Simple SELECT without GROUP, LIMIT offset, HAVING, DISTINCT
- Almost all kinds of INSERT without subqueries
added 17 commits
November 22, 2018 21:02
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
===========================================
- Coverage 77.47% 76.51% -0.96%
===========================================
Files 142 149 +7
Lines 10251 11115 +864
===========================================
+ Hits 7942 8505 +563
- Misses 1684 1910 +226
- Partials 625 700 +75 |
Codecov Report
@@ Coverage Diff @@
## develop #129 +/- ##
==========================================
+ Coverage 76.74% 77% +0.26%
==========================================
Files 146 151 +5
Lines 10890 11313 +423
==========================================
+ Hits 8357 8712 +355
- Misses 1845 1898 +53
- Partials 688 703 +15 |
added 5 commits
December 6, 2018 20:50
xq262144
reviewed
Dec 17, 2018
xq262144
reviewed
Dec 17, 2018
leventeliu
reviewed
Dec 17, 2018
shard/engine_test.go
Outdated
| So(err, ShouldNotBeNil) | ||
| So(its, ShouldEqual, -1) | ||
| }) | ||
| } No newline at end of file |
xq262144
reviewed
Dec 17, 2018
| rowCh <-chan []interface{} | ||
| ) | ||
| for i, ins := range instructions { | ||
| colNames, _, rowCh, err = plan.selector(ctx, errCh, stopCh, ins, TempTableRowBufSize) |
Contributor
There was a problem hiding this comment.
colNames may not be the same schema as the original table.
xq262144
reviewed
Dec 17, 2018
ggicci
approved these changes
Dec 29, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. Please review @laodouya @auxten @xq262144 @leventeliu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.