Add support for any amount of wheels in Holonomic drive#219
Open
allenftc wants to merge 2 commits intoFTCLib:masterfrom
Open
Add support for any amount of wheels in Holonomic drive#219allenftc wants to merge 2 commits intoFTCLib:masterfrom
allenftc wants to merge 2 commits intoFTCLib:masterfrom
Conversation
Member
|
Has this been tested? Additionally, I would rather have H-Drive be modified to support any amount of wheels which was originally the goal but it currently only supports 3 or 4 instead of making it a separate class. |
Author
|
My class basically replaces it, and I tested it with 5 wheels. Not sure about other amounts though, I will have to do some further testing once our team has the time. |
Member
|
If you could do that and provide it to me, that would be appreciated. I don't want to merge something untested and/or unverified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Requests
Please note that we accept pull requests from anyone, but that does not mean it will be merged.
What kind of change does this PR introduce?
Did this PR introduce a breaking change?
Please make sure your PR satisfies the requirements of the contributing page