Adds ability to record creator name field and a description field in map editor#58
Open
rafbel wants to merge 3 commits intoFreeCol:masterfrom
Open
Adds ability to record creator name field and a description field in map editor#58rafbel wants to merge 3 commits intoFreeCol:masterfrom
rafbel wants to merge 3 commits intoFreeCol:masterfrom
Conversation
Member
|
I think this is the wrong approach. The description is a translatable string and should be in the messages file. The author could just be an optional field in Map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, map creators can't save the author and a brief description of their maps as mentioned in the SourceForge forum thread https://sourceforge.net/p/freecol/improvement-requests/232/.
I created a little dialog that saves this information and then saves it in the XML document using a separate XML element. Here is a preview: