Skip to content

Adding dependency setuptools and grpcio#3865

Closed
samuelloza wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
samuelloza:master
Closed

Adding dependency setuptools and grpcio#3865
samuelloza wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
samuelloza:master

Conversation

@samuelloza
Copy link
Copy Markdown

Adding dependency setuptools and grpcio

@samuelloza samuelloza requested a review from a team as a code owner May 23, 2020 00:08
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 23, 2020
@samuelloza
Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 23, 2020
@kurtisvg
Copy link
Copy Markdown
Contributor

@starsaminf Can you provide some motivation on these changes? Neither of these requirements look like they should need to be explicitly listed

@busunkim96
Copy link
Copy Markdown
Contributor

I can confirm that grpcio will be pulled in via google-api-core (a dependency of all the GAPIC libraries). Similarly a minimum version of setuptools is required by google-auth.

@leahecole
Copy link
Copy Markdown
Collaborator

leahecole commented May 27, 2020

Alright since we've determined these are brought in somewhere else, I'm going to go ahead and close this.

@leahecole leahecole closed this May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants