feat: fetch and display holiday pay policy in PolicyList#1522
Merged
krisxcrash merged 7 commits intomainfrom Apr 13, 2026
Merged
feat: fetch and display holiday pay policy in PolicyList#1522krisxcrash merged 7 commits intomainfrom
krisxcrash merged 7 commits intomainfrom
Conversation
Include the company's holiday pay policy in the TimeOff PolicyList
by calling GET /v1/companies/{company_uuid}/holiday_pay_policy.
Gracefully handles 204 (no policy) and 404 responses without error.
Adds holiday-specific delete flow and confirmation dialog.
e50b581 to
1ebf081
Compare
serikjensen
approved these changes
Apr 10, 2026
dmortal
reviewed
Apr 10, 2026
| }) | ||
| const timeOffPolicies = policiesData.timeOffPolicies ?? [] | ||
|
|
||
| const { data: holidayData } = useHolidayPayPoliciesGet( |
Contributor
There was a problem hiding this comment.
we probably need to deal with errors here as well - dashboard hooks use buildQueryErrorHandling utility for this. also, do we need to worry about isLoading?
Contributor
Author
There was a problem hiding this comment.
that's a great callout!
dmortal
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v1/companies/{company_uuid}/holiday_pay_policycall in thePolicyListcomponent to fetch and display the company's holiday pay policy alongside regular time off policiesuseHolidayPayPoliciesDeleteMutationwith a dedicated confirmation dialogTest plan
TIME_OFF_VIEW_POLICYwithpolicyType: 'holiday'npm run format:checkpasses