contrib/ivorysql_ora/sql/ora_raw_long.sql (1)

47-55: Consider adding 1–2 edge assertions to strengthen rawtohex coverage.

Current tests are solid; adding a lowercase-hex input and an escaped-text input would better guard output normalization and text conversion behavior.

♻️ Suggested test additions

 -- rawtohex
 SELECT sys.rawtohex('\xDEADBEEF'::bytea);
+SELECT sys.rawtohex('\xdeadbeef'::bytea);
 SELECT sys.rawtohex('\xFF'::raw);
 SELECT sys.rawtohex('hello'::text);
+SELECT sys.rawtohex(E'a\\b'::text);
 SELECT sys.rawtohex('hello'::varchar2);
 SELECT sys.rawtohex(sys.hextoraw('DEADBEEF'));
 SELECT sys.rawtohex(NULL) IS NULL;
 SELECT sys.rawtohex('') IS NULL;
 SELECT sys.rawtohex('\x'::bytea) IS NULL;

As per coding guidelines, **/sql/*.sql: “Test SQL files. Ensure comprehensive coverage of features.”

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/ivorysql_ora/sql/ora_raw_long.sql` around lines 47 - 55, Tests for
rawtohex lack a lowercase hex input and an escaped-text input to validate
normalization and text conversion; add assertions invoking sys.rawtohex with a
lowercase hex via sys.hextoraw('deadbeef') and with an escaped textual bytea
like sys.rawtohex(E'\\xDEADBEEF'::bytea) (or another escaped-text variant) and
assert expected normalized uppercase hex results (and NULL behavior where
applicable) to the existing rawtohex tests alongside the existing sys.hextoraw
and bytea/text cases.

contrib/ivorysql_ora/src/builtin_functions/builtin_functions--1.0.sql (1)

964-970: Reduce overload drift by delegating text to the bytea overload.

Both overloads implement the same null/empty logic; delegating keeps behavior centralized and easier to maintain.

♻️ Suggested refactor

 CREATE OR REPLACE FUNCTION sys.rawtohex(text)
 RETURNS varchar2
-AS $$ SELECT CASE WHEN pg_catalog.octet_length($1) > 0 THEN upper(pg_catalog.encode($1::bytea, 'hex'))::varchar2 END; $$ 
+AS $$ SELECT sys.rawtohex($1::bytea); $$
 LANGUAGE SQL
 PARALLEL SAFE
 STRICT
 IMMUTABLE;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contrib/ivorysql_ora/src/builtin_functions/builtin_functions--1.0.sql` around
lines 964 - 970, Replace the duplicated logic in sys.rawtohex(text) by
delegating to the existing bytea overload: change the function body to simply
SELECT sys.rawtohex($1::bytea); so the text overload casts its input to bytea
and reuses sys.rawtohex(bytea) (keeping the same function signature, LANGUAGE
SQL, PARALLEL SAFE, STRICT, IMMUTABLE attributes) to centralize null/empty
handling.