Virtualize operation in ModbusMaster;Refactor MessageFrame implementation#183
Open
Haale wants to merge 1 commit intoNModbus:masterfrom
Open
Virtualize operation in ModbusMaster;Refactor MessageFrame implementation#183Haale wants to merge 1 commit intoNModbus:masterfrom
Haale wants to merge 1 commit intoNModbus:masterfrom
Conversation
…tion in AbstractModbusMessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.one can inherit from the ModbusMaster and override some operation funciton easily.
2.If a new Message sub-class inherit from exsiting class (like ReadHoldingInputRegistersRequest) and override the ProtocalUnit building procedure,the MessageFrame doesn't change over beacause its building is implemented by ModbusMessageImpl (which is fixed)
3.ignore all the csproj file change due to its adapting to my local SDK installed and environment