Skip to content

Removed Deprecated Methods#759

Draft
darbyjack wants to merge 1 commit intomasterfrom
deprecated-removal
Draft

Removed Deprecated Methods#759
darbyjack wants to merge 1 commit intomasterfrom
deprecated-removal

Conversation

@darbyjack
Copy link
Copy Markdown
Member

@darbyjack darbyjack commented Dec 3, 2021

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

In version 2.10.9, we marked a bunch of older API methods as deprecated and to be removed in version 2.10.11. The time is coming soon to release this new version so the methods marked for removal should be removed. Merge this last before the 2.11.0 release.

Closes N/A

@Andre601
Copy link
Copy Markdown
Collaborator

Andre601 commented Dec 3, 2021

Uh.... Some are marked to get removed in 2.11.0 while you mention 2.10.11, so which one is it now?

@darbyjack
Copy link
Copy Markdown
Member Author

Yup, that's a typo on my end. The next version should be 2.11.0 and then removed normally.

@Andre601
Copy link
Copy Markdown
Collaborator

How's the status on this PR?
Anything else to update/remove?

@Andre601 Andre601 added the Type: Enhancement New feature or request label Dec 14, 2021
@darbyjack
Copy link
Copy Markdown
Member Author

Going to hold back on this. Decided it was best to not take the chance to break stuff before PAPI3.

@Andre601
Copy link
Copy Markdown
Collaborator

*sigh* so you do the bukkit aproach here...
Just remove it! If people use it it's their fault. They had plenty of time. We should just release 2.11.0

And be honest: Do you REALLY believe PAPI3 will enter any alpha or beta state in the next year, given its current state?
I state the facts here.

@emilyy-dev
Copy link
Copy Markdown
Contributor

https://semver.org/

@Andre601
Copy link
Copy Markdown
Collaborator

https://semver.org/

Semver isn't everything.
While we can follow it, is it not required. Not to mention did we ANNOUNCE through the annotations used that the stuff WILL be removed in 2.11.0, so now changing that would also not be nice.

If we announce something, no matter in what way, should we stick with it.

@emilyy-dev
Copy link
Copy Markdown
Contributor

emilyy-dev commented Dec 15, 2021

https://semver.org/

Semver isn't everything. While we can follow it, is it not required. Not to mention did we ANNOUNCE through the annotations used that the stuff WILL be removed in 2.11.0, so now changing that would also not be nice.

If we announce something, no matter in what way, should we stick with it.

I disagree, semver is a globally identifiable way of defining breaking changes, additions and patches/bug fixes across versions that guarantees if my software changes a library version from X.Y.Z to X.W.V there will be no ABI breakages, regardless of context. A proper versioning system should always be put before some silly annotation pinky promise "no matter in what way, should we stick with it".

@Andre601 Andre601 added the Target: Code This issue/PR is targeting the Code of PlaceholderAPI label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants