Skip to content

Pin setup-python action to a commit hash - part 2#7493

Open
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:setup-python-pin-2
Open

Pin setup-python action to a commit hash - part 2#7493
ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
ShaharNaveh:setup-python-pin-2

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Mar 24, 2026

extracted from #7491
Probably blocked until #7483 is merged

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configurations: pinned action references to exact commits for greater stability.
    • Corrected the code coverage action input to ensure coverage files are recognized.
    • Minor workflow formatting cleanups for readability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

📝 Walkthrough

Walkthrough

Pinned actions/setup-python to a specific commit SHA in multiple cron CI jobs and changed the Codecov upload input from file: to files: format in the workflow YAML.

Changes

Cohort / File(s) Summary
Workflow Configuration
​.github/workflows/cron-ci.yaml
Pinned actions/setup-python from v6.2.0 to commit a309ff8b426b58ec0e2a45f0f869d46889d02405 in codecov, whatsleft, and benchmark jobs; changed Codecov input from file: ./codecov.lcov to files: ./codecov.lcov; minor blank-line formatting around steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • youknowone

Poem

🐇 I nibble strings of YAML with care,
Pinning a hash so builds run fair,
Codecov rows stand tidy in line,
Cron jobs hum — the pipeline's fine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: pinning the setup-python action to a specific commit hash across multiple workflow jobs.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/cron-ci.yaml:
- Around line 53-54: The YAML uses a block scalar for the codecov action's files
input which v5 expects as a comma-separated string; update the `files` input for
the Codecov step (the `files` key used with the codecov action invocation) to a
single-line, comma-separated value (e.g., "path/to/file1, path/to/file2")
instead of the multi-line block scalar so the action parses it correctly.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 2292b149-9795-47ff-b60e-505240d7053d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c01615 and ae37379.

📒 Files selected for processing (2)
  • .github/workflows/cron-ci.yaml
  • .github/workflows/pr-format.yaml

@ShaharNaveh ShaharNaveh changed the title Pin setup-python action to a commit hash - part 2 Pin setup-python action to a commit hash - part 2 Mar 24, 2026
@youknowone
Copy link
Member

oh, please chcek the action lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants