Update test reference files for SIZEOF_DOUBLE precision fix#1348
Update test reference files for SIZEOF_DOUBLE precision fix#1348BrentBaccala wants to merge 1 commit intoSingular:spielwiesefrom
Conversation
Upstream commit ec0b927 fixed a typo (SIZEOF_DOUBE -> SIZEOF_DOUBLE) in libpolys/coeffs/numbers.h, changing SHORT_REAL_LENGTH from 6 to 16. This increased float output precision across Singular. PR Singular#1339 updated one affected reference file (Example_1_8_7), but 17 other tests in non-comprehensive lists still had stale reference files. Affected tests: - Short: rInit, solve_s, bug_53, bug_55, bug_div - Long: tropical - Manual: number_pi, simplex, simplexOut, solve, fglm_solve, laguerre_solve, lex_solve, triangLf_solve, triangL_solve, triangM_solve, triang_solve All changes are exclusively float precision differences (more digits, scientific notation formatting, "complex:N digits" display strings). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
Note for reviewers: none of the 17 tests in this PR are exercised by
So CI will not detect any regression in these reference files. Verification was done locally:
This comment was written by an AI assistant (Claude) on behalf of Brent Baccala ([email protected]). |
|
Here's a bash command that will show all of the diffs in this commit:
There are numerous places where the diffs do not appear to be caused by the SIZEOF_DOUBLE fix, but are still pretty cosmetic - changes from standard notation to scientific notation; changes in spacing. |
|
Thanks a lot for pinpointing this! We were already planning to add more tests to the standard CI suite to avoid issues like that. If it is fine with you I would like to pursue the following route: I add first these tests (referenced as non-required) to the CI. This will then include the 17 tests affected here, as well as that of #1348. Once they are exercised in the CI and fail, we rerun the CI on your PR, verify green and merge. |
|
Very good! If you're looking to update the CI suite, I'd suggest looking at #1276 as well. It adds the ability to SSH into a test runner, which I've found to be quite useful at times. I just updated it to make sure it's current. |
Summary
.res.gz.uuand.statfiles for 17 tests affected by theSIZEOF_DOUBLEfix (commit ec0b927)Example_1_8_7; this PR covers the remaining affected testsDetails
Commit ec0b927 fixed a typo (
SIZEOF_DOUBE→SIZEOF_DOUBLE) inlibpolys/coeffs/numbers.h, changingSHORT_REAL_LENGTHfrom 6 to 16. This increased float output precision, causing reference file mismatches in tests that print floating-point results.Affected tests (17 total):
bug_53,bug_55,bug_div,rInit,solve_stropicalfglm_solve,laguerre_solve,lex_solve,number_pi,simplex,simplexOut,solve,triangL_solve,triangLf_solve,triangM_solve,triang_solveAll changes are exclusively float precision differences (6-10 digits → 16 digits, scientific notation formatting). Reference files regenerated with
regress.cmd -g -mto preserve existing stat measurements from other machines.Test plan
This PR was researched and written by an AI assistant (Claude) on behalf of Brent Baccala ([email protected]), based on analysis of test failures traced to the SIZEOF_DOUBLE precision fix (ec0b927).